Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly pass codecov-token to composite action #40138

Merged
merged 1 commit into from
Jun 8, 2024

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Jun 8, 2024

Turns out that in order to pass secret to a composite action you need to pass it as input.

Further follow up on #40136 and #40128


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Turns out that in order to pass secret to a composite action you
need to pass it as input.

Further follow up on apache#40136 and apache#40128
@potiuk potiuk merged commit 3c8cd1c into apache:main Jun 8, 2024
64 checks passed
@potiuk potiuk deleted the fix-codecov-token-passed-as-input branch June 8, 2024 12:18
@potiuk
Copy link
Member Author

potiuk commented Jun 8, 2024

Merging. We will not see if it works until it's merged :)

romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
Turns out that in order to pass secret to a composite action you
need to pass it as input.

Further follow up on apache#40136 and apache#40128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants