Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix importlib_metadata import in aws utils #40134

Merged
merged 2 commits into from
Jun 8, 2024
Merged

Fix importlib_metadata import in aws utils #40134

merged 2 commits into from
Jun 8, 2024

Conversation

eladkal
Copy link
Contributor

@eladkal eladkal commented Jun 8, 2024

closes: #40127

@eladkal eladkal requested a review from o-nikolas as a code owner June 8, 2024 07:45
@boring-cyborg boring-cyborg bot added area:providers provider:amazon AWS/Amazon - related issues labels Jun 8, 2024
@potiuk potiuk merged commit 22bd188 into apache:main Jun 8, 2024
49 checks passed
@Taragolis
Copy link
Contributor

I bit late with my 2 cents
We don't need fallback, because required modules and functional exists in stdlib from python 3.8

@eladkal eladkal deleted the bedrock branch June 8, 2024 11:10
@Taragolis Taragolis mentioned this pull request Jun 8, 2024
Merged
@eladkal eladkal mentioned this pull request Jun 22, 2024
Closed
96 tasks
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
@eladkal @romsharon98
Fix importlib_metadata import in aws utils (apache#40134)
a40df8a 
* Fix `importlib_metadata` import in aws utils

* reorder imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potiuk potiuk potiuk approved these changes

@hussein-awala hussein-awala hussein-awala approved these changes

@ferruzzi ferruzzi Awaiting requested review from ferruzzi

@Taragolis Taragolis Awaiting requested review from Taragolis

@vincbeck vincbeck Awaiting requested review from vincbeck

@o-nikolas o-nikolas Awaiting requested review from o-nikolas

Assignees
No one assigned
Labels
area:providers provider:amazon AWS/Amazon - related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Amazon Provider v8.23.0 importlib_metadata module import error
4 participants
@eladkal @Taragolis @potiuk @hussein-awala