Expllicitly skip FAB tests for compatiblity tests on 2.7 and 2.8 #40059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Providers[fab] tests are generally excluded when backwards compatibility tests for 2.7 and 2.8 are run, however in some situation when selective checks determine that API tests should be run as well (for example when FAB code is modified), the FAB tests are also added to list of test types. This PR explicitly skips the whole TEST_TYPE execution in case Airfow 2.7 or 2.8 are supposed to be installed when running the tests.
9ccac6b to
6bccc31
Compare
eladkal
reviewed
Jun 5, 2024
eladkal
approved these changes
Jun 5, 2024
jedcunningham
approved these changes
Jun 5, 2024
|
Thanks Jarek! |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jun 6, 2024
The apache#40059 added an exception for fab tests not to run on old airflow releases but it was wrong doing return instead of exit
fdemiane
pushed a commit
to fdemiane/airflow
that referenced
this pull request
Jun 6, 2024
…che#40059) The Providers[fab] tests are generally excluded when backwards compatibility tests for 2.7 and 2.8 are run, however in some situation when selective checks determine that API tests should be run as well (for example when FAB code is modified), the FAB tests are also added to list of test types. This PR explicitly skips the whole TEST_TYPE execution in case Airfow 2.7 or 2.8 are supposed to be installed when running the tests.
jedcunningham
pushed a commit
that referenced
this pull request
Jun 6, 2024
) The #40059 added an exception for fab tests not to run on old airflow releases but it was wrong doing return instead of exit
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
…che#40059) The Providers[fab] tests are generally excluded when backwards compatibility tests for 2.7 and 2.8 are run, however in some situation when selective checks determine that API tests should be run as well (for example when FAB code is modified), the FAB tests are also added to list of test types. This PR explicitly skips the whole TEST_TYPE execution in case Airfow 2.7 or 2.8 are supposed to be installed when running the tests.
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
…che#40089) The apache#40059 added an exception for fab tests not to run on old airflow releases but it was wrong doing return instead of exit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Providers[fab] tests are generally excluded when backwards
compatibility tests for 2.7 and 2.8 are run, however in some situation
when selective checks determine that API tests should be run as well
(for example when FAB code is modified), the FAB tests are also
added to list of test types.
This PR explicitly skips the whole TEST_TYPE execution in case
Airfow 2.7 or 2.8 are supposed to be installed when running the tests.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.