-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync v2-9-stable with v2-9-test to release 2.9.2 #40050
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 1608231)
It's json, not python, so we need lowercase bools. (cherry picked from commit 6150179)
(cherry picked from commit 710d28f)
Previously it would show the message as coming from context logger module and not the actual call site. (cherry picked from commit acc2338)
(cherry picked from commit f142e9b)
(cherry picked from commit 10e34d3)
When using the TaskHandlerWithCustomFormatter to add a prefix to logs, it was previously adding the prefix multiple times. This happened because it was being called multiple times from logging_mixin.py, and worsened because even when the handler's formatter was a TimezoneAware formatter (to include UTC offset), it was still adding an additional prefix. Because of this, I felt that any solution outside of the TaskHandlerWithCustomFormatter itself would either require a restructuring of the handlers' structure or slow down execution for all other handlers. And so, the solution I settled on was to add to TaskHandlerWithCustomFormatter's initial 'if' statement a simple 'or self.prefix_jinja_template is not None', so that it returns if the prefix had already been set. This is similar to what is done by the ElasticSearch es_task_handler.py. Note: also fixed the documentation's example for the handler, as the previous one was incorrect and didn't work. (cherry picked from commit 61d1c95)
(cherry picked from commit a1c873c)
* Fix static file caching is disabled in Airflow Webserver. In Airflow 2.3.0, it's Flask version is bumped up to 2.0.x Flask 2.0.x has some breaking changes. one of them is about `SEND_FILE_MAX_AGE_DEFAULT`. It affect static file's Expires value on HTTP response header. and the default value is changed from 12 hours to None on that version. in order to enable static file caching in airflow webserver. it needs explicitly configration of `SEND_FILE_MAX_AGE_DEFAULT` in Flask. * Fix typo * Fix code's formatting with ruff (cherry picked from commit d396533)
(cherry picked from commit 4a568d3)
(cherry picked from commit 9eac305)
(cherry picked from commit b594a8d)
* Add note about Trigger reload * fix (cherry picked from commit 0f9ad98)
* Provide extra tip on labeling DynamicTaskMapping (cherry picked from commit 4d5591a)
Mini scheduler issues are rare and hard to debug. Chances are the problem won't be reproducible after enabling debug logging. (cherry picked from commit 38e003c)
48320cb
to
bb937f6
Compare
(cherry picked from commit d525ec5)
(cherry picked from commit 0ac8553)
(cherry picked from commit a65a837)
With dynamic project depdencies, the requirements for airlfow are calculated dymamically from hatch_build.py, however cache invalidation key for k8s tests only included pyproject.toml so when colorlog has been bumped in @39453, main build continued to use cache from old colorlog. This PR adds also hatch_build.py to cache id calculation (cherry picked from commit f5c86ed)
This was the same parameter but inconsistently named across the CI/Selective checks. This PR fixes the inconsistency and changes it to `docker-cache` across the board. (cherry picked from commit d11a943)
* Replace to broad exceptions into the Dev * Add changes according to the review Co-authored-by: Jarek Potiuk <jarek@potiuk.com> Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> * RuntimeError -> SystemExit if detect it run in __main__ Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> --------- Co-authored-by: Jarek Potiuk <jarek@potiuk.com> Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> (cherry picked from commit cc901cd)
* Add "use self-hosted runners" to CI setup In anticipation of switching commiter PRs to use public runners, we are adding the feature of applying the "use self-hosted runner" to a PR to make it use self-hosted runners. * Update dev/breeze/doc/ci/04_selective_checks.md Co-authored-by: Pankaj Koti <pankajkoti699@gmail.com> * Update dev/breeze/doc/ci/04_selective_checks.md Co-authored-by: Pankaj Koti <pankajkoti699@gmail.com> * Update dev/breeze/doc/ci/04_selective_checks.md Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com> * Update dev/breeze/doc/ci/04_selective_checks.md Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com> * Update dev/breeze/src/airflow_breeze/utils/selective_checks.py Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com> --------- Co-authored-by: Pankaj Koti <pankajkoti699@gmail.com> Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com> (cherry picked from commit d2f11f0)
(cherry picked from commit 5d10c4a)
The new requests-kerberos has a slightly different approach for parsing urls and extracting hostname from url causes a problem with "mock cannot be compared to int" when mock is returned as URL. This PR fixes it by hard-coding returned URL in the mock that is being returned in this case. (cherry picked from commit 32fd29d)
(cherry picked from commit 483d408)
The 0.291.0 version of yandex provider introduced mypy typing that conflicts with the way yandex provider uses it and should be fixed See yandex-cloud/python-sdk#106 (cherry picked from commit 53e6739)
jscheffl
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code from the 3 PRs/fixes from my side look good.
Looks like we'll need 79042cf to pass the mypy check |
(cherry picked from commit 79042cf)
eladkal
approved these changes
Jun 6, 2024
potiuk
approved these changes
Jun 6, 2024
hussein-awala
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, LGTM
phanikumv
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:API
Airflow's REST/HTTP API
area:CLI
area:core-operators
Operators, Sensors and hooks within Core Airflow
area:db-migrations
PRs with DB migration
area:dev-tools
area:lineage
area:production-image
Production image improvements and fixes
area:Scheduler
including HA (high availability) scheduler
area:Triggerer
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time for
2.9.2rc1
!