Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DbtCloudRunJobOperator to Use Correct Status Parameters for reuse_existing_run #40048

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

boraberke
Copy link
Contributor

@boraberke boraberke commented Jun 4, 2024

dbt Cloud API accepts status__in parameter as

...&status_in=[1,2,3]

instead of

...&status_in=1&status_in=2&status_in=3

Closes: #40047


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boraberke boraberke marked this pull request as ready for review June 4, 2024 18:19
@boraberke boraberke requested a review from josh-fell as a code owner June 4, 2024 18:19
Copy link
Contributor

@shahar1 shahar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josh-fell josh-fell merged commit 5d22786 into apache:main Jun 4, 2024
49 checks passed
fdemiane pushed a commit to fdemiane/airflow that referenced this pull request Jun 6, 2024
…use_existing_run` (apache#40048)

* Pass value of `NON_TERMINAL_STATUSES` enum instead of itself

* Pass `NON_TERMINAL_STATUSES` as string
syedahsn pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Jun 7, 2024
…use_existing_run` (apache#40048)

* Pass value of `NON_TERMINAL_STATUSES` enum instead of itself

* Pass `NON_TERMINAL_STATUSES` as string
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
…use_existing_run` (apache#40048)

* Pass value of `NON_TERMINAL_STATUSES` enum instead of itself

* Pass `NON_TERMINAL_STATUSES` as string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DbtCloudRunJobOperator reuse_existing_run flag does not work properly
3 participants