-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ordering key option for PubSubPublishMessageOperator GCP Operator #39955
Added ordering key option for PubSubPublishMessageOperator GCP Operator #39955
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
cc: @VladaZakharova or someone from your team could have a look on this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
6ab2efc
to
4457302
Compare
I think it needs some more fixes. |
It's fixed now Jarek, thanks |
5658689
to
6802b86
Compare
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Cool :) |
…or (apache#39955) * feature/gcp-pubsub-operator-ordering-key * fix provider checks test --------- Co-authored-by: Mehdi GATI <mehdi_gati@ext.carrefour.com>
…or (apache#39955) * feature/gcp-pubsub-operator-ordering-key * fix provider checks test --------- Co-authored-by: Mehdi GATI <mehdi_gati@ext.carrefour.com>
resolves #39940 : Added ordering key option for PubSubPublishMessageOperator GCP Operator
By adding support for ordering keys in the PubSubPublishMessageOperator, Airflow users would be able to leverage this Cloud Pub/Sub feature and ensure that their published messages are delivered in the desired order, enabling more robust and reliable data processing pipelines.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.