Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ordering key option for PubSubPublishMessageOperator GCP Operator #39955

Merged

Conversation

mehdigati
Copy link
Contributor

@mehdigati mehdigati commented May 30, 2024

resolves #39940 : Added ordering key option for PubSubPublishMessageOperator GCP Operator
By adding support for ordering keys in the PubSubPublishMessageOperator, Airflow users would be able to leverage this Cloud Pub/Sub feature and ensure that their published messages are delivered in the desired order, enabling more robust and reliable data processing pipelines.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels May 30, 2024
Copy link

boring-cyborg bot commented May 30, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@mehdigati mehdigati changed the title Added ordering key option for PubSubPublishMessageOperator GCP Operator resolves #39940 : Added ordering key option for PubSubPublishMessageOperator GCP Operator May 31, 2024
@mehdigati mehdigati changed the title resolves #39940 : Added ordering key option for PubSubPublishMessageOperator GCP Operator Added ordering key option for PubSubPublishMessageOperator GCP Operator May 31, 2024
@Taragolis
Copy link
Contributor

cc: @VladaZakharova or someone from your team could have a look on this PR?

Copy link
Contributor

@shahar1 shahar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@molcay molcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@potiuk potiuk force-pushed the feature/gcp-pubsub-operator-ordering-key branch from 6ab2efc to 4457302 Compare June 1, 2024 11:12
@potiuk
Copy link
Member

potiuk commented Jun 1, 2024

I think it needs some more fixes.

@mehdigati
Copy link
Contributor Author

It's fixed now Jarek, thanks

@mehdigati mehdigati force-pushed the feature/gcp-pubsub-operator-ordering-key branch from 5658689 to 6802b86 Compare June 1, 2024 23:15
@potiuk potiuk merged commit 385d79b into apache:main Jun 2, 2024
49 checks passed
Copy link

boring-cyborg bot commented Jun 2, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@potiuk
Copy link
Member

potiuk commented Jun 2, 2024

Cool :)

fdemiane pushed a commit to fdemiane/airflow that referenced this pull request Jun 6, 2024
…or (apache#39955)

* feature/gcp-pubsub-operator-ordering-key

* fix provider checks test

---------

Co-authored-by: Mehdi GATI <mehdi_gati@ext.carrefour.com>
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
…or (apache#39955)

* feature/gcp-pubsub-operator-ordering-key

* fix provider checks test

---------

Co-authored-by: Mehdi GATI <mehdi_gati@ext.carrefour.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ordering key in GCP PubSub operator PubSubPublishMessageOperator
5 participants