Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openlineage] typo: wrong OpenLineage facet key in spec #39782

Merged
merged 1 commit into from
May 23, 2024
Merged

[openlineage] typo: wrong OpenLineage facet key in spec #39782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airflow/providers/google/cloud/openlineage/BigQueryErrorRunFacet.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
},
"type": "object",
"properties": {
"bigQueryJob": {
"bigQuery_error": {
"$ref": "#/$defs/BigQueryErrorRunFacet"
}
}
Expand Down
6 changes: 1 addition & 5 deletions airflow/providers/google/cloud/openlineage/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ def get_facets(self, job_id: str):
if hasattr(self, "log"):
self.log.warning("Cannot retrieve job details from BigQuery.Client. %s", e, exc_info=True)
exception_msg = traceback.format_exc()
# TODO: remove ErrorMessageRunFacet in next release
# TODO: remove BigQueryErrorRunFacet in next release
run_facets.update(
{
"errorMessage": ErrorMessageRunFacet(
Expand All @@ -282,10 +282,6 @@ def get_facets(self, job_id: str):
}
)
deduplicated_outputs = self._deduplicate_outputs(outputs)
# For complex scripts there can be multiple outputs - in that case keep them all in `outputs` and
# leave the `output` empty to avoid providing misleading information. When the script has a single
# output (f.e. a single statement with some variable declarations), treat it as a regular non-script
# job and put the output in `output` as an addition to new `outputs`. `output` is deprecated.
return inputs, deduplicated_outputs, run_facets

def _deduplicate_outputs(self, outputs: list[Dataset | None]) -> list[Dataset]:
Expand Down