Allow FTPHook to change port number #39465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
dirrao
requested changes
May 8, 2024
|
Yes, I'll do the test case over the weekend. |
vincbeck
reviewed
May 13, 2024
|
I did some tests and fixed a tiny bug, when no port is supplied. |
vincbeck
approved these changes
May 14, 2024
amoghrajesh
reviewed
May 16, 2024
amoghrajesh
approved these changes
May 17, 2024
|
@VelmiraPetkova can you please fix static checks? |
|
Sorry for the delay. I updated the PR. Could you please take a look? Thank you! |
amoghrajesh
approved these changes
May 27, 2024
eladkal
reviewed
May 27, 2024
potiuk
approved these changes
May 27, 2024
|
The failing integration test case is a flake - mssql does not have enough time to start. This has been fixed in #39866 |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
fdemiane
pushed a commit
to fdemiane/airflow
that referenced
this pull request
Jun 6, 2024
* Allow FTPHook to change port * Add integration tests and fix a bug * Styling fix * Add logging of the FTP host and port * Update logging and test styling * styling fix * formatting change * Update airflow/providers/ftp/hooks/ftp.py * fix log statement formatting --------- Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>
2 tasks
96 tasks
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
* Allow FTPHook to change port * Add integration tests and fix a bug * Styling fix * Add logging of the FTP host and port * Update logging and test styling * styling fix * formatting change * Update airflow/providers/ftp/hooks/ftp.py * fix log statement formatting --------- Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow FTPHook to use a custom FTP port number
closes: #39308