-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add deferrable support to DatabricksNotebookOperator
#39295
Merged
pankajkoti
merged 28 commits into
apache:main
from
rawwar:kalyan/db-notebook-deferrable-support
May 14, 2024
Merged
add deferrable support to DatabricksNotebookOperator
#39295
pankajkoti
merged 28 commits into
apache:main
from
rawwar:kalyan/db-notebook-deferrable-support
May 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…db-notebook-deferrable-support Signed-off-by: kalyanr <kalyan.ben10@live.com>
…db-notebook-deferrable-support
…db-notebook-deferrable-support
pankajkoti
reviewed
May 6, 2024
rawwar
commented
May 6, 2024
Lee-W
reviewed
May 6, 2024
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Lee-W
reviewed
May 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
implementation looks good, but it would be better if we can add some test
…db-notebook-deferrable-support
…db-notebook-deferrable-support
rawwar
commented
May 12, 2024
Lee-W
approved these changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nitpick. Everything else looks good to me
…db-notebook-deferrable-support
pankajkoti
approved these changes
May 14, 2024
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
related: apache#39178 This PR intends to make DatabricksNotebookOperator deferrable
pankajkoti
added a commit
to astronomer/astro-provider-databricks
that referenced
this pull request
Aug 8, 2024
As part of Astronomer's internal plans and decisions, we've decided to contribute the existing functionality provided by the operators and plugins in this repository to the official Apache Airflow Databricks provider. To achieve this, we submitted the following PRs to the Airflow provider: 1. apache/airflow#39178 2. apache/airflow#39771 3. apache/airflow#40013 4. apache/airflow#40724 5. apache/airflow#39295 All functionality has now been contributed to the Airflow Databricks provider, and ongoing support will be maintained there. As a result, we're deprecating the operators and plugins in this repository. Users are encouraged to transition to the official Apache Airflow Databricks provider as soon as possible. The migration process is straightforward—simply update the import path to point to the Airflow provider and ensure that you install `apache-airflow-providers-databricks>=6.8.0`, which includes all the contributions mentioned above. closes: astronomer/issues-airflow#715
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #39178
This PR intends to make
DatabricksNotebookOperator
deferrable