Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add deferrable support to DatabricksNotebookOperator #39295

Merged
merged 28 commits into from
May 14, 2024

Conversation

rawwar
Copy link
Collaborator

@rawwar rawwar commented Apr 28, 2024

related: #39178

This PR intends to make DatabricksNotebookOperator deferrable

@rawwar rawwar marked this pull request as ready for review May 5, 2024 10:48
@rawwar rawwar requested a review from pankajkoti May 6, 2024 10:32
@rawwar rawwar requested a review from Lee-W May 6, 2024 11:38
Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implementation looks good, but it would be better if we can add some test

@rawwar rawwar requested a review from Lee-W May 12, 2024 00:54
Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nitpick. Everything else looks good to me

@pankajkoti pankajkoti merged commit 1e4663f into apache:main May 14, 2024
40 checks passed
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
related: apache#39178

This PR intends to make DatabricksNotebookOperator deferrable
pankajkoti added a commit to astronomer/astro-provider-databricks that referenced this pull request Aug 8, 2024
As part of Astronomer's internal plans and decisions, we've decided to contribute the existing functionality provided by the operators and plugins in this repository to the official Apache Airflow Databricks provider. To achieve this, we submitted the following PRs to the Airflow provider:

1. apache/airflow#39178
2. apache/airflow#39771
3. apache/airflow#40013
4. apache/airflow#40724
5. apache/airflow#39295

All functionality has now been contributed to the Airflow Databricks provider, and ongoing support will be maintained there. As a result, we're deprecating the operators and plugins in this repository. Users are encouraged to transition to the official Apache Airflow Databricks provider as soon as possible. The migration process is straightforward—simply update the import path to point to the Airflow provider and ensure that you install `apache-airflow-providers-databricks>=6.8.0`, which includes all the contributions mentioned above.

closes: astronomer/issues-airflow#715
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants