Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PROD image package installation in CI #39035

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Apr 15, 2024

When PROD image packages are installed in in CI, the local sources should not be present in the image, also constraints from sources shoudl replace the one downloaded from main.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk potiuk added the default versions only When assigned to PR - only default python version is used for CI tests label Apr 15, 2024
@boring-cyborg boring-cyborg bot added area:dev-tools area:production-image Production image improvements and fixes labels Apr 15, 2024
When PROD image packages are installed in in CI, the local sources
should not be present in the image, also constraints from sources
shoudl replace the one downloaded from main.
@potiuk potiuk force-pushed the fix-prod-image-ci-preparation branch from 34da29f to 7ddc9bc Compare April 15, 2024 16:01
@potiuk potiuk marked this pull request as ready for review April 15, 2024 16:01
@potiuk potiuk requested review from Taragolis and vincbeck April 15, 2024 16:02
@potiuk potiuk merged commit 246f697 into main Apr 15, 2024
67 checks passed
potiuk added a commit to potiuk/airflow that referenced this pull request Apr 15, 2024
Follow up after apache#39035 where local airflow sources have been
removed from PROD image built in CI. The k8s image for tests also
added the sources when preparing the modified image. This is now
avoided - the --no-copy-local-sources is used in CI to avoid it.
potiuk added a commit that referenced this pull request Apr 15, 2024
Follow up after #39035 where local airflow sources have been
removed from PROD image built in CI. The k8s image for tests also
added the sources when preparing the modified image. This is now
avoided - the --no-copy-local-sources is used in CI to avoid it.
@potiuk potiuk added this to the Airflow 2.9.1 milestone Apr 16, 2024
ephraimbuddy pushed a commit that referenced this pull request Apr 16, 2024
When PROD image packages are installed in in CI, the local sources
should not be present in the image, also constraints from sources
shoudl replace the one downloaded from main.

(cherry picked from commit 246f697)
ephraimbuddy pushed a commit that referenced this pull request Apr 16, 2024
Follow up after #39035 where local airflow sources have been
removed from PROD image built in CI. The k8s image for tests also
added the sources when preparing the modified image. This is now
avoided - the --no-copy-local-sources is used in CI to avoid it.

(cherry picked from commit 1e9d3d1)
ephraimbuddy pushed a commit that referenced this pull request Apr 16, 2024
When PROD image packages are installed in in CI, the local sources
should not be present in the image, also constraints from sources
shoudl replace the one downloaded from main.

(cherry picked from commit 246f697)
ephraimbuddy pushed a commit that referenced this pull request Apr 16, 2024
Follow up after #39035 where local airflow sources have been
removed from PROD image built in CI. The k8s image for tests also
added the sources when preparing the modified image. This is now
avoided - the --no-copy-local-sources is used in CI to avoid it.

(cherry picked from commit 1e9d3d1)
@eladkal eladkal deleted the fix-prod-image-ci-preparation branch June 29, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools area:production-image Production image improvements and fixes default versions only When assigned to PR - only default python version is used for CI tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants