-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PROD image package installation in CI #39035
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When PROD image packages are installed in in CI, the local sources should not be present in the image, also constraints from sources shoudl replace the one downloaded from main.
34da29f
to
7ddc9bc
Compare
Taragolis
approved these changes
Apr 15, 2024
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Apr 15, 2024
Follow up after apache#39035 where local airflow sources have been removed from PROD image built in CI. The k8s image for tests also added the sources when preparing the modified image. This is now avoided - the --no-copy-local-sources is used in CI to avoid it.
potiuk
added a commit
that referenced
this pull request
Apr 15, 2024
Follow up after #39035 where local airflow sources have been removed from PROD image built in CI. The k8s image for tests also added the sources when preparing the modified image. This is now avoided - the --no-copy-local-sources is used in CI to avoid it.
ephraimbuddy
pushed a commit
that referenced
this pull request
Apr 16, 2024
When PROD image packages are installed in in CI, the local sources should not be present in the image, also constraints from sources shoudl replace the one downloaded from main. (cherry picked from commit 246f697)
ephraimbuddy
pushed a commit
that referenced
this pull request
Apr 16, 2024
When PROD image packages are installed in in CI, the local sources should not be present in the image, also constraints from sources shoudl replace the one downloaded from main. (cherry picked from commit 246f697)
56 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:dev-tools
area:production-image
Production image improvements and fixes
default versions only
When assigned to PR - only default python version is used for CI tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When PROD image packages are installed in in CI, the local sources should not be present in the image, also constraints from sources shoudl replace the one downloaded from main.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.