Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry logic for RPC calls #38910

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

dstandish
Copy link
Contributor

@dstandish dstandish commented Apr 10, 2024

I have found that when RPC server restarts it can take 30-60s for the server to be able to respond to RPC calls. This implements exponential wait for that case. 10 might seem excessive but I found that 3 or 5 didn't always do the trick.

@dstandish dstandish requested review from potiuk and vincbeck April 10, 2024 19:53
@dstandish dstandish marked this pull request as ready for review April 10, 2024 19:53
@dstandish dstandish merged commit cdc7f19 into apache:main Apr 11, 2024
39 checks passed
@dstandish dstandish deleted the add-retry-logic-for-rpc-calls branch April 11, 2024 02:47
potiuk added a commit to potiuk/airflow that referenced this pull request Apr 12, 2024
The WASB blob tests started to fail intermittently after retries were
implemented in apache#38910. Without understanding all the details, it
seems that the async tests run in xdist mode of tests suffer from the
bug of pytest-xdist - because the thread that runs some of the tests
is not main and it likely interferes with signals handling and is
likely an incarnation of
pytest-dev/pytest-xdist#620
(which still needs to be solved in pytest-xdist)

Since those two tests that keeps on failing intermittently and the other
tests have been marked as db_test - likely for the same reason, we
should simply mark all the module as db_test to avoid the interference.
potiuk added a commit that referenced this pull request Apr 12, 2024
The WASB blob tests started to fail intermittently after retries were
implemented in #38910. Without understanding all the details, it
seems that the async tests run in xdist mode of tests suffer from the
bug of pytest-xdist - because the thread that runs some of the tests
is not main and it likely interferes with signals handling and is
likely an incarnation of
pytest-dev/pytest-xdist#620
(which still needs to be solved in pytest-xdist)

Since those two tests that keeps on failing intermittently and the other
tests have been marked as db_test - likely for the same reason, we
should simply mark all the module as db_test to avoid the interference.
@utkarsharma2 utkarsharma2 added changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) AIP-44 Airflow Internal API labels Jun 3, 2024
@dstandish dstandish added this to the Airflow 2.10.0 milestone Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AIP-44 Airflow Internal API changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants