Rename pre-commit scripts, drop pre_commit_ prefix #38667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't reference those scripts only by name anywhere (always by the full path or the pre-commit ID). The pre-commit part is already evident from them being inside a pre_commit directory. This makes paths shorter and those files a bit easier to browse in a file browser (including ls).
c7718c2 to
4bc1d63
Compare
|
Sure. If it makes someone's life easier :). The original reason why it had the prefix was that it's been quite evident from script opened in IDE, that it's a pre-commit script without looking at the path, but this is a very subtle nuance so if making scripts names shorter makes it better. Those scripts are anyhow rarely modfied. |
potiuk
approved these changes
Apr 2, 2024
potiuk
pushed a commit
that referenced
this pull request
Apr 6, 2024
We don't reference those scripts only by name anywhere (always by the full path or the pre-commit ID). The pre-commit part is already evident from them being inside a pre_commit directory. This makes paths shorter and those files a bit easier to browse in a file browser (including ls). (cherry picked from commit 725a9b6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't reference those scripts only by name anywhere (always by the full path or the pre-commit ID). The pre-commit part is already evident from them being inside a pre_commit directory. This makes paths shorter and those files a bit easier to browse in a file browser (including ls).