Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inherit key "verify" from env into session so that kv_client can read it properly #38614

Merged
merged 14 commits into from
May 15, 2024
+66 −0
Merged

inherit key "verify" from env into session so that kv_client can read it properly #38614

Changes from 3 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
fe16480
inherit key verify from env into session so that kv_client can read i…
chz8494 Mar 29, 2024
a17b61b
add assurance
chz8494 Mar 29, 2024
26e164f
Merge branch 'main' into fix_vault_private_ssl
chz8494 Mar 29, 2024
a1f7758
Update airflow/providers/hashicorp/_internal_client/vault_client.py
chz8494 Mar 30, 2024
602d276
Update airflow/providers/hashicorp/_internal_client/vault_client.py
chz8494 Mar 30, 2024
b278c06
Merge branch 'main' into fix_vault_private_ssl
chz8494 Mar 30, 2024
edbff79
add test for verify and fix False case for session dict key condition
chz8494 Apr 2, 2024
5a698ae
fix missing ,
chz8494 Apr 3, 2024
1418c80
fix "
chz8494 Apr 5, 2024
cc97559
Merge branch 'main' into fix_vault_private_ssl
chz8494 Apr 11, 2024
bb88612
fix typo space
chz8494 May 2, 2024
e915bed
Merge branch 'main' into fix_vault_private_ssl
chz8494 May 2, 2024
2c628c9
use not
chz8494 May 2, 2024
44a43eb
Merge branch 'fix_vault_private_ssl' of github.com:chz8494/airflow in…
chz8494 May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions airflow/providers/hashicorp/_internal_client/vault_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,9 @@ def _client(self) -> hvac.Client:
session = Session()
session.mount("http://", adapter)
session.mount("https://", adapter)
if self.kwargs is not None and "verify" in self.kwargs:
if self.kwargs["verify"] is not None:
session.verify = self.kwargs["verify"]
self.kwargs["session"] = session

_client = hvac.Client(url=self.url, **self.kwargs)
Expand Down