Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to get metadata from GCS blob in GCSHook #38398

Merged
merged 5 commits into from
May 27, 2024
Merged

Conversation

jalengg
Copy link
Contributor

@jalengg jalengg commented Mar 22, 2024

  • Background: GCS blobs can be associated with metadata to make tracking and validating data easier. The GCSHook doesn't yet allow for the metadata attribute to be exposed, although it supports uploading of blobs and associating metadata with them.
  • Add get_metadata method to GCSHook
  • The get_metadata function would retrieve metadata from blobs which already reside in a GCS bucket.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Mar 22, 2024
Copy link

boring-cyborg bot commented Mar 22, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@jalengg jalengg changed the title Allow metadata Add method to get metadata from GCS blob in GCSHook Mar 22, 2024
@jalengg jalengg marked this pull request as ready for review March 22, 2024 21:58
@jalengg jalengg requested a review from dirrao March 25, 2024 02:53
@jalengg jalengg requested a review from amoghrajesh March 27, 2024 06:53
Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me! Running the workflow

@jalengg jalengg requested a review from eladkal April 4, 2024 05:28
@molcay
Copy link
Contributor

molcay commented Apr 26, 2024

LGTM

Just a small thing: it can be good to squash the commits

Copy link
Contributor

@shahar1 shahar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please rebase the latest changes

Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1
@eladkal WDYT?

Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I just rebased the branch. Lets confirm CI is green

@potiuk
Copy link
Member

potiuk commented May 27, 2024

LGTM I just rebased the branch. Lets confirm CI is green

Looks good.

@potiuk potiuk merged commit 23e03db into apache:main May 27, 2024
41 checks passed
Copy link

boring-cyborg bot commented May 27, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

fdemiane pushed a commit to fdemiane/airflow that referenced this pull request Jun 6, 2024
* Adding get metadata to gcs hook

* unit test

* Spelling and rm fstrings

* test for blob not found

* fix pytest raises, add match regex
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
* Adding get metadata to gcs hook

* unit test

* Spelling and rm fstrings

* test for blob not found

* fix pytest raises, add match regex
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants