Remove unnecessary cache for MyPy jobs #38162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MyPy jobs started to fail pretty randomly in docs and dev builds and the main suspect for that is cache - either pre-commit cache or docker cache stored locally in docker volume. We can actually disable the cache, because a) pre-commit cache is not really needed for this job as we only one venv to create and b) the docker volume cache in case of CI job is at most harmless as we exect to start all jobs from a clean state.
Taragolis
approved these changes
Mar 14, 2024
hussein-awala
approved these changes
Mar 14, 2024
|
one mypy check failed (but for a different reason - machine evicted likely) . Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MyPy jobs started to fail pretty randomly in docs and dev builds and the main suspect for that is cache - either pre-commit cache or docker cache stored locally in docker volume.
We can actually disable the cache, because a) pre-commit cache is not really needed for this job as we only one venv to create and b) the docker volume cache in case of CI job is at most harmless as we exect to start all jobs from a clean state.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.