Better and more complete cleanup for CI jobs #38152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
commented
Mar 14, 2024
Some of the recent refactors caused a problem that mypy jobs started to return errors likely resulting from a bad cache volume remaining after the jobs completed. This PR extracts cleanup step to a separate, composite action and uses this action everywhere, including pruning docker including all containers and volumes to avoid the issue.
a84dd8f to
0488340
Compare
|
Actually - we have to leave the old code - because it is needed to handle some "spilled" checkout problems and the shared action cannot be run before checkout - so we have chicken-egg problem :( .. This version is a more complete fix. |
|
Looks like the cleanup works - at least all |
|
The ARM CI failure might be ignored - it's not relevant for the fix here. |
uranusjr
approved these changes
Mar 14, 2024
dirrao
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the recent refactors caused a problem that mypy jobs started to return errors likely resulting from a bad cache volume remaining after the jobs completed.
This PR extracts cleanup step to a separate, composite action and uses this action everywhere, including pruning docker including all containers and volumes to avoid the issue.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.