Get rid of lowest-direct resolution in no-constraint upgrades with uv #38109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we fall-back to no-constraint mode in uv, we used so far lowest-direct resolution - but it could cause a really old set of versions to be installed with some strange pyproject.toml errors (for example zenpy==2.0.32 had a buggy pyproject.toml and it caused editable local install to fail.
dirrao
approved these changes
Mar 13, 2024
|
That failure should also be fixed by #38110, but anyhow it's likely better to keep default resolution strategy for those upgrades. |
drajguru
pushed a commit
to drajguru/airflow
that referenced
this pull request
Mar 14, 2024
…apache#38109) When we fall-back to no-constraint mode in uv, we used so far lowest-direct resolution - but it could cause a really old set of versions to be installed with some strange pyproject.toml errors (for example zenpy==2.0.32 had a buggy pyproject.toml and it caused editable local install to fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we fall-back to no-constraint mode in uv, we used so far lowest-direct resolution - but it could cause a really old set of versions to be installed with some strange pyproject.toml errors (for example zenpy==2.0.32 had a buggy pyproject.toml and it caused editable local install to fail.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.