Fix spark operator log retrieval from driver #38106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eladkal mind taking a look? think this minor change can fix |
8563e18 to
f62045b
Compare
dirrao
approved these changes
Mar 13, 2024
sure |
7e94ea5 to
2a47d16
Compare
|
@dirrao tests added! |
39bf49d to
79bb051
Compare
|
LGTM that makes sense since the older version of k8soperator uses that base container name and not supported multiple container |
2 tasks
fb1783c to
f294edd
Compare
Signed-off-by: Hai Nguyen <quanghai.ng1512@gmail.com>
Signed-off-by: Hai Nguyen <quanghai.ng1512@gmail.com>
42d4b9e to
11e0681
Compare
Signed-off-by: Harry <quanghai.ng1512@gmail.com>
11e0681 to
ef0efa3
Compare
eylonronen
approved these changes
Mar 31, 2024
hussein-awala
approved these changes
Mar 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related logs:
closes: #37681
Overriding default BASE_CONTAINER_NAME assigns the
container_logsattribute correctly in further steps, so that in execution airflow can get logs from the correct container.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.