Rename SparkSubmitOperator/SparkJDBCOperator fields' names to comply with templated fields validation
#38051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6fdb8be to
77f2840
Compare
f085c59 to
4d4d17d
Compare
Taragolis
reviewed
Mar 12, 2024
4d4d17d to
f69fe0f
Compare
f69fe0f to
c209fbf
Compare
SparkSubmitOperator's fields' names to comply with templated fields validationSparkSubmitOperator/SparkJDBCOperator fields' names to comply with templated fields validation
c209fbf to
fcb14c9
Compare
|
There are conflicts :( |
fcb14c9 to
b858597
Compare
Fixed; it's expected as we remove an entry in each PR from |
3fc0882 to
02ef213
Compare
… fields validation
02ef213 to
d26bda4
Compare
eladkal
approved these changes
Mar 16, 2024
eladkal
reviewed
Mar 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #36484
This PR renames
SparkSubmitOperator's fields' names to comply with templated fields validation.It also optimizes derived
SparkJDBCOperatorconstructor by delegating parents' attributes to**kwargsto avoid repetition of parameters (templated fields were among them).Tests were added for both operators to ensure correct templating.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.