Revert "Add system test to test the AWS auth manager (#37947)" #38004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 39befdc.
jedcunningham
approved these changes
Mar 9, 2024
|
Had a chat with @vincbeck this morning, he is going to look into the reverted commit and re-submit it once he figures out what happened. |
vincbeck
added a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Mar 11, 2024
…37947)" (apache#38004)" This reverts commit 89f5cde.
|
Fix: #38044 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 39befdc.
Something in this commit broke a bunch of other system tests. It looks like every AWS system test which gets a value from SSM stopped working once this was merged. Since I'm not sure what else may be affected, and it's the end of the day on a Friday, I want to revert this commit and we can have a look at it on Monday to pinpoint the problem.
System Test Dashboard is here to see the blast radius, timing, and hopefully the fix.
Testing
Ran the tests and they failed, reverted this commit, rebuild ci-image, re-ran a couple of the tests again and the ones I ran all passed.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.