-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deferrable mode for RunPipelineJobOperator #37969
Deferrable mode for RunPipelineJobOperator #37969
Conversation
adbe881
to
1d54a9b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good to me. Left a few nitpicks
airflow/providers/google/cloud/operators/vertex_ai/pipeline_job.py
Outdated
Show resolved
Hide resolved
1d54a9b
to
f482fd9
Compare
f482fd9
to
dd46e98
Compare
Hi @potiuk ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few nitpicks. but overall looks good to me
airflow/providers/google/cloud/operators/vertex_ai/pipeline_job.py
Outdated
Show resolved
Hide resolved
dd46e98
to
18272e6
Compare
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
List of changes:
RunPipelineJobOperator
;^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.