Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate sync parameter for CreateHyperparameterTuningJobOperator #37938

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Deprecate sync parameter for CreateHyperparameterTuningJobOperator #37938

merged 1 commit into from
Mar 7, 2024
+33 −69

Conversation

moiseenkov
Copy link
Contributor

Refactored CreateHyperparameterTuningJobOperator:

  • deprecated the sync parameter because it brings confusion when deferrable mode is presented;
  • slightly refactored a link persistence so users could have UI access to the created job immediately after its creation (way before its completion).

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Mar 6, 2024
@moiseenkov moiseenkov force-pushed the vertex-ai-create-hyperparameter-tuning-job-refactoring branch 4 times, most recently from ebe63ab to 53d6579 Compare March 7, 2024 13:25
@moiseenkov moiseenkov force-pushed the vertex-ai-create-hyperparameter-tuning-job-refactoring branch from 53d6579 to a8df54e Compare March 7, 2024 14:58
@potiuk potiuk merged commit 46666af into apache:main Mar 7, 2024
55 checks passed
@eladkal eladkal mentioned this pull request Apr 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potiuk potiuk potiuk approved these changes

Assignees
No one assigned
Labels
area:providers provider:google Google (including GCP) related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moiseenkov @potiuk