-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the method BaseAuthManager.is_authorized_custom_view
abstract
#37915
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also a bit confused by the menu related changes.
Also is it possible to get unit test coverage of the plugin path? Since it was missed before
Hmmm, I can understand the MENU change looks unrelated. I can possibly split the PR in 2 if that helps. I can also a unit test to cover the plugin path |
Actually, let me explain why I combined the two. The idea initially was to call Though, I am still happy to make this effort if you think that would make the review easier |
@o-nikolas @potiuk any concerns on why I also included the "MENU" change in this PR? Happy to change something if needed |
LGTM |
While testing auth managers I realized that
is_authorized_custom_view
is also called when custom pages are defined in plugins. Therefore, we need to make the methodBaseAuthManager.is_authorized_custom_view
abstract so that auth managers can also work in environments with custom pages defined in plugins.This is technically a breaking change but:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.