Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow default requests parameters like proxy to be defined in extra options field of a Airflow HTTP Connection #36733

Merged
merged 23 commits into from
Jan 13, 2024

Conversation

dabla
Copy link
Contributor

@dabla dabla commented Jan 11, 2024


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

…_options which are used by the SimpleHttpOperator to avoid a InvalidHeader exception while instantiating the requests Session
…e instantiated request Session as default value
Copy link

boring-cyborg bot commented Jan 11, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@Taragolis
Copy link
Contributor

Also required to update the documentation for the connection:

Extras (optional)
Specify headers in json format.

@dabla
Copy link
Contributor Author

dabla commented Jan 11, 2024

Also required to update the documentation for the connection:

Extras (optional)
Specify headers in json format.

I've updated the documentation. Thank you for letting me know :)

Copy link
Contributor

@dirrao dirrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dabla
Copy link
Contributor Author

dabla commented Jan 11, 2024

I see some checks are failing. Can you check and fix them? I would suggest to install pre-commit hook for static checks. https://www.google.com/url?sa=t&rct=j&q=&esrc=s&source=web&cd=&ved=2ahUKEwi4lubf1tWDAxWISWwGHdq7APoQFnoECA4QAQ&url=https%3A%2F%2Fgithub.com%2Fapache%2Fairflow%2Fblob%2Fmain%2FSTATIC_CODE_CHECKS.rst&usg=AOvVaw3_chGWjXp6V2QRaCTm_fyE&opi=89978449

Normally failing checks should be fixed now, thanks for the suggestion will look into that :)

@dabla dabla requested review from aritra24 and dirrao January 12, 2024 07:15
@jscheffl
Copy link
Contributor

Just a small type checking glitch, I assume then we are ready to merge :-D

@dabla
Copy link
Contributor Author

dabla commented Jan 13, 2024

Just a small type checking glitch, I assume then we are ready to merge :-D

Fixed it, my pre-commit hook isn't fully working yet (on Windows) but almost there (I think)

@jscheffl jscheffl merged commit c2d02b4 into apache:main Jan 13, 2024
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants