-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow default requests parameters like proxy to be defined in extra options field of a Airflow HTTP Connection #36733
Allow default requests parameters like proxy to be defined in extra options field of a Airflow HTTP Connection #36733
Conversation
…_options which are used by the SimpleHttpOperator to avoid a InvalidHeader exception while instantiating the requests Session
…e instantiated request Session as default value
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
Also required to update the documentation for the connection: airflow/docs/apache-airflow-providers-http/connections/http.rst Lines 56 to 57 in d7bc217
|
I've updated the documentation. Thank you for letting me know :) |
… in extra_options and added async test for AsyncHttpOperator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see some checks are failing. Can you check and fix them?
I would suggest to install pre-commit hook for static checks.
https://www.google.com/url?sa=t&rct=j&q=&esrc=s&source=web&cd=&ved=2ahUKEwi4lubf1tWDAxWISWwGHdq7APoQFnoECA4QAQ&url=https%3A%2F%2Fgithub.com%2Fapache%2Fairflow%2Fblob%2Fmain%2FSTATIC_CODE_CHECKS.rst&usg=AOvVaw3_chGWjXp6V2QRaCTm_fyE&opi=89978449
Normally failing checks should be fixed now, thanks for the suggestion will look into that :) |
…om_connection into one test as suggested by aritra24
Just a small type checking glitch, I assume then we are ready to merge :-D |
Fixed it, my pre-commit hook isn't fully working yet (on Windows) but almost there (I think) |
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.