Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Yandex Cloud Lockbox secrets backend #36449

Merged

Conversation

ImpressionableRaccoon
Copy link
Contributor

This PR added support for Yandex Cloud Lockbox secrets backend to Yandex Cloud provider 😎


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link

boring-cyborg bot commented Dec 27, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@ImpressionableRaccoon ImpressionableRaccoon force-pushed the add-lockbox-secrets-backend branch 3 times, most recently from 5ad5fe4 to 57d0d35 Compare December 27, 2023 10:57
Copy link
Contributor

@Taragolis Taragolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with with Yandex.Cloud and sdk so this is just some generic comments

@ImpressionableRaccoon ImpressionableRaccoon marked this pull request as draft December 28, 2023 21:19
@ImpressionableRaccoon ImpressionableRaccoon force-pushed the add-lockbox-secrets-backend branch from 158dc82 to b6e8787 Compare January 10, 2024 16:58
@ImpressionableRaccoon ImpressionableRaccoon marked this pull request as ready for review January 10, 2024 18:01
@ImpressionableRaccoon ImpressionableRaccoon marked this pull request as draft January 12, 2024 14:39
@ImpressionableRaccoon ImpressionableRaccoon force-pushed the add-lockbox-secrets-backend branch from b6e8787 to defbc56 Compare January 15, 2024 10:54
Copy link
Contributor

@Piatachock Piatachock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM. Mostly nit-s, endpoint parameter is important tho.

@ImpressionableRaccoon ImpressionableRaccoon force-pushed the add-lockbox-secrets-backend branch 2 times, most recently from aa31fb2 to b1ce06e Compare January 17, 2024 13:14
Copy link
Contributor

@Piatachock Piatachock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from Yandex

@ImpressionableRaccoon ImpressionableRaccoon marked this pull request as ready for review January 17, 2024 14:12
Copy link
Contributor

@Taragolis Taragolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My main concern about Connection ID into the Secrets Manager, see appropriate conversation

@ImpressionableRaccoon ImpressionableRaccoon force-pushed the add-lockbox-secrets-backend branch from b1ce06e to e0acf30 Compare January 18, 2024 10:37
@Taragolis Taragolis dismissed their stale review January 19, 2024 14:07

dismiss change request

@ImpressionableRaccoon ImpressionableRaccoon force-pushed the add-lockbox-secrets-backend branch from e0acf30 to be6f387 Compare January 19, 2024 14:38
@ImpressionableRaccoon
Copy link
Contributor Author

I think it's ready to merge

@ImpressionableRaccoon ImpressionableRaccoon force-pushed the add-lockbox-secrets-backend branch from be6f387 to 2622b59 Compare January 22, 2024 14:41
@Taragolis Taragolis merged commit 12ccb5f into apache:main Jan 25, 2024
54 checks passed
Copy link

boring-cyborg bot commented Jan 25, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants