Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BREEZE.rst with different test example #36234

Merged
merged 1 commit into from
Dec 27, 2023
Merged

Conversation

Bowrna
Copy link
Contributor

@Bowrna Bowrna commented Dec 15, 2023

Updating the breeze docs with different pytest example as the function mentioned in the example is removed from the test_core.py


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link
Contributor

@josh-fell josh-fell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably worth updating this reference in TESTING.rst as well.

@Bowrna
Copy link
Contributor Author

Bowrna commented Dec 15, 2023

static checks are failing with following message Skipping breeze pre-commit as SKIP_BREEZE_PRE_COMMIT is set. However it works fine when I run the breeze static-checks --only-my-changes and the Update output of breeze commands in BREEZE.rst check passed. Any idea why this check fails?

@potiuk
Copy link
Member

potiuk commented Dec 16, 2023

This code is wrong likely - it should be exit(0)

   if os.environ.get("SKIP_BREEZE_PRE_COMMITS"):
        console.print("[yellow]Skipping breeze pre-commit as SKIP_BREEZE_PRE_COMMIT is set")
        sys.exit(1)

Updating the breeze docs with different pytest example as the function mentioned in the example is removed from the test_core.py
@potiuk potiuk merged commit 71c726d into apache:main Dec 27, 2023
potiuk pushed a commit that referenced this pull request Dec 30, 2023
Updating the breeze docs with different pytest example as the function mentioned in the example is removed from the test_core.py

(cherry picked from commit 71c726d)
@potiuk potiuk added this to the Airflow 2.8.1 milestone Dec 30, 2023
@potiuk potiuk added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants