-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Providers requirements for every python version #35086
Providers requirements for every python version #35086
Conversation
318fbd8
to
a21f956
Compare
Comment 1: It takes a long time to build the images with all the airflow versions in but we can optimize it later by pushing them to ghcr.io and using them as cache (should be separate step). |
All looks good I have just a few general comments (and some improvement proposals / test results will come as inline comments).
|
Thank you for the reviews. I agree, both updating the release process and image caching are important and should be done in follow up steps. @potiuk I will address the other comments and do the image caching as a follow up right after. Seems cool to do and I would like to give it a try, I'll let you know if I need some help :) |
05f0107
to
ec78617
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fantastic :)
b76f3f1
to
da1cc5b
Compare
Made a few adjustments to allow for more flexibility in the provider_ids/provider_versions combo. This way we can:
|
c5f37ec
to
9541638
Compare
9541638
to
06da7cc
Compare
Whoa. Let me take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. That looks really good and flexible to handle both initial generation and regular. Only a small NIT.
Images need to be regenerated after my changes :( |
e00f6fd
to
7719593
Compare
* Restructure output directory to handle multiple python versions * Generate for all historical versions * Add output to parallel mode * Split all airflow images building to a separate command * Allow generating per provider requirements * Update parameters help description (cherry picked from commit 3fa75e9)
Allow to generate providers requirements for all python versions. Use all python versions compatible with the
associated_airflow_version
of the provider.Parallelize image building for different python versions (images with all the airflow versions pre-installed)
Update the output file structure to look like this:
