-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add testcases to ensure that 'soft_fail' argument is respected when running ExternalTaskSensor #34652
Add testcases to ensure that 'soft_fail' argument is respected when running ExternalTaskSensor #34652
Conversation
dag.test()
and Respect 'soft_fail' argument when running ExternalTaskSensor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to add this patch in the core operators, we already fixed it, and for that we add the comment (TODO: remove this if block when min_airflow_version is set to higher than 2.7.1
)
However, you can keep the tests (only the tests for the execute/patch method).
|
e3017dc
to
8f306d1
Compare
dag.test()
and Respect 'soft_fail' argument when running ExternalTaskSensor
This PR intends to add test cases to ensure that the soft_fail argument in ExternalTaskSensor is respected.
related: #34497, #33401