Remove Pydantic 1 compatibility code #33998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cd66123 to
223e458
Compare
potiuk
approved these changes
Sep 1, 2023
vincbeck
approved these changes
Sep 1, 2023
|
Static checks failure |
Lee-W
approved these changes
Sep 4, 2023
hussein-awala
approved these changes
Sep 4, 2023
ephraimbuddy
approved these changes
Sep 4, 2023
223e458 to
22746ba
Compare
ephraimbuddy
pushed a commit
that referenced
this pull request
Sep 4, 2023
(cherry picked from commit 601b9cd)
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Sep 4, 2023
The apache#33956 and apache#33998 updated limits for Pydantic to Pydantic 2 only and removed Pydantic 1 compatibility. However it turns out that some of important 3rd-party libraries have not yet upgraded and it will make it impossible to install them on Airflow 2.7.1+ if we keep the limit. For now we bring back Pydantic 1 compatibility, we remove the limit and filter the warnings that made us remove the compatibility code.
potiuk
added a commit
that referenced
this pull request
Sep 4, 2023
The #33956 and #33998 updated limits for Pydantic to Pydantic 2 only and removed Pydantic 1 compatibility. However it turns out that some of important 3rd-party libraries have not yet upgraded and it will make it impossible to install them on Airflow 2.7.1+ if we keep the limit. For now we bring back Pydantic 1 compatibility, we remove the limit and filter the warnings that made us remove the compatibility code.
ephraimbuddy
pushed a commit
that referenced
this pull request
Sep 4, 2023
The #33956 and #33998 updated limits for Pydantic to Pydantic 2 only and removed Pydantic 1 compatibility. However it turns out that some of important 3rd-party libraries have not yet upgraded and it will make it impossible to install them on Airflow 2.7.1+ if we keep the limit. For now we bring back Pydantic 1 compatibility, we remove the limit and filter the warnings that made us remove the compatibility code. (cherry picked from commit 30ddfc5)
97 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think these are irrelevant after #33956