Consolidate import and usage of itertools #33479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we want to consolidate (not strictly necessary) I’d prefer the full |
kaxil
reviewed
Aug 18, 2023
b928305 to
c94feea
Compare
uranusjr
reviewed
Aug 20, 2023
airflow/lineage/__init__.py
Outdated
| @@ -142,7 +142,7 @@ def wrapper(self, context, *args, **kwargs): | |||
| _inlets = self.xcom_pull( | |||
| context, task_ids=task_ids, dag_id=self.dag_id, key=PIPELINE_OUTLETS, session=session | |||
| ) | |||
| self.inlets.extend(i for i in itertools.chain.from_iterable(_inlets)) | |||
| self.inlets.extend(itertools.chain.from_iterable(_inlets)) | |||
There was a problem hiding this comment.
This can just be
Suggested change
| self.inlets.extend(itertools.chain.from_iterable(_inlets)) | |
| self.inlets.extend(i for it in _inlets for i in it) |
but itertools has readability advantages.
uranusjr
reviewed
Aug 20, 2023
| for argument, default in itertools.zip_longest(arguments, defaults, fillvalue=None): | ||
| for argument, default in zip(arguments, defaults): |
There was a problem hiding this comment.
In the subsequent line:
if argument is None or default is None:
continueall the lines that come from zip_longest but are ignored in zip are ignored anyway.
524bb1c to
1f89278
Compare
|
Conflicts :( |
uranusjr
approved these changes
Aug 21, 2023
potiuk
approved these changes
Aug 21, 2023
ephraimbuddy
pushed a commit
that referenced
this pull request
Aug 28, 2023
(cherry picked from commit 95a930b)
97 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.