Simplify 'X for X in Y' to 'Y' where applicable #33453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hussein-awala
approved these changes
Aug 16, 2023
| @@ -134,7 +134,7 @@ def pytest_print(text): | |||
| # It is very unlikely that the user wants to display only numbers, but probably | |||
| # the user just wants to count the queries. | |||
| exit_stack.enter_context(count_queries(print_fn=pytest_print)) | |||
| elif any(c for c in ["time", "trace", "sql", "parameters"]): | |||
| elif any(c in columns for c in ["time", "trace", "sql", "parameters"]): | |||
vincbeck
approved these changes
Aug 16, 2023
uranusjr
reviewed
Aug 17, 2023
uranusjr
reviewed
Aug 17, 2023
uranusjr
reviewed
Aug 18, 2023
| @@ -557,7 +557,7 @@ def test__write_local_data_files_csv_does_not_write_on_empty_rows(self): | |||
| with pytest.raises(StopIteration): | |||
| next(files)["file_handle"] | |||
|
|
|||
| assert len([f for f in files]) == 0 | |||
| assert not list(files) | |||
There was a problem hiding this comment.
Suggested change
| assert not list(files) | |
| with pytest.raises(StopIteration): | |
| next(files) |
Alternative approach. Shouldn’t be too much difference in practice (especially in a test).
There was a problem hiding this comment.
This is really elegant. Anyway, since the previous block already expects a StopIteration, we do not have to repeat it here. I'll remove it altogether.
uranusjr
approved these changes
Aug 18, 2023
potiuk
approved these changes
Aug 20, 2023
ephraimbuddy
pushed a commit
that referenced
this pull request
Aug 28, 2023
(cherry picked from commit 7700fb1)
97 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify loops without condition
X for X in Yto bareY, or convert it tolist()orset()oriter()if needed.