D205 Support - Stragglers #33301
Merged
D205 Support - Stragglers #33301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
uranusjr
reviewed
Aug 11, 2023
airflow/utils/setup_teardown.py
Outdated
| @@ -181,7 +181,10 @@ def _push_tasks(cls, operator: AbstractOperator | list[AbstractOperator], setup: | |||
|
|
|||
| @classmethod | |||
| def _update_teardown_downstream(cls, operator: AbstractOperator | list[AbstractOperator]): | |||
| """This recursively goes through the tasks downstream of the setup in the context manager, | |||
| """ | |||
| Update _teardown_downstream_of_setup. | |||
There was a problem hiding this comment.
@dstandish Any idea to better describe this function? (Also _update_setup_upstream below)
There was a problem hiding this comment.
I think I've found suitable phrasing here and for the other method below.
potiuk
approved these changes
Aug 13, 2023
# Conflicts: # airflow/triggers/external_task.py # airflow/utils/setup_teardown.py
uranusjr
approved these changes
Aug 15, 2023
ferruzzi
added a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Aug 17, 2023
ephraimbuddy
pushed a commit
that referenced
this pull request
Aug 28, 2023
(cherry picked from commit 9bf68ad)
97 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #10742
D205 asserts that all docstrings must have a one-line summary ending in a period. If there is more than one sentence then there must be a blank line before the rest of the docstring. Meeting these requirements could be as simple as adding a newline, or might require some rephrasing.
There are almost a thousand violations in the repo so we're going to have to take this in bites.
PLEASE NOTE
There should be zero logic changes in this PR, only changes to docstrings and whitespace. If you see otherwise, please call it out.
Included in this chunk
A handful of files which weren't in clusters big enough to warrant their own PRs.
To test
If you comment out this line and run pre-commit in main you will get 92 errors. After these changes, only 76 remain and no files in the list above should be on the list. After uncommenting that line and rerunning pre-commits, there should be zero regressions.