Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Simplify code in providers/amazon #33222

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

eumiro
Copy link
Contributor

@eumiro eumiro commented Aug 8, 2023

No description provided.

@eumiro eumiro force-pushed the providers-amazon branch 2 times, most recently from 8c61734 to 8256a1c Compare August 8, 2023 19:56
@eumiro eumiro force-pushed the providers-amazon branch from 8256a1c to 7575a77 Compare August 8, 2023 19:57
@eladkal eladkal requested review from ferruzzi and vincbeck August 9, 2023 03:45
@vincbeck vincbeck merged commit 83bd60f into apache:main Aug 9, 2023
@eumiro eumiro deleted the providers-amazon branch August 9, 2023 17:51
@ferruzzi
Copy link
Contributor

ferruzzi commented Aug 9, 2023

I got half way through reviewing it last night and was going to finish this afternoon. Ah well. :P Thanks for the cleanup!

@o-nikolas
Copy link
Contributor

I got half way through reviewing it last night and was going to finish this afternoon. Ah well. :P Thanks for the cleanup!

@ferruzzi I think another pass can't hurt, if you find something then we can always fix it in a follow-up PR. I'm not sure the goal of this PR, since there's no description, but there is a large surface area of code/logic changing here, something can easily slip in with those types of PRs!

@potiuk
Copy link
Member

potiuk commented Aug 10, 2023

@ferruzzi I think another pass can't hurt, if you find something then we can always fix it in a follow-up PR. I'm not sure the goal of this PR, since there's no description, but there is a large surface area of code/logic changing here, something can easily slip in with those types of PRs!

I did a pass too. Could not see anything odd. FYI @o-nikolas -> this is a series of cleanups that @eumiro is apparently on a quest of - he had one huge PR to improve some of our less-than-ideal code snippets and I asked him to break it into series of smaller PRs focused on "common" areas - this one is the "aws" provider one.

@vincbeck
Copy link
Contributor

Sorry If I merged too fast folks, I did not see anything odd and everything made sense to me. I'll be more patient next time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants