Fix test_example_dags #32714
Merged
Fix test_example_dags #32714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should move the |
uranusjr
reviewed
Jul 24, 2023
uranusjr
reviewed
Jul 24, 2023
dddf19e to
c3e1dfe
Compare
uranusjr
approved these changes
Jul 27, 2023
By going up to `parents[3]` we were going outside the repository root, luckily(or unluckily the repo folder is also named `airflow` so the pattern `airflow/**/example_dags/example_*.py` still worked, but `tests/system/providers/**/example_*.py` wasn't being used. This discovered 2 new errors: - `example_local_to_wasb.py` was trivial to fix - `example_redis_publish.py`is more interesting: this one fails because `RedisPubSubSensor` constructor calls Redis.pubsub().subscribe(), which just hangs and DagBag fails with timeout. For now I'm just deleting this operator from the example.
c3e1dfe to
28e6b21
Compare
|
@ahidalgob Looks like there is a conflict to resolve. Can you take a look when you have a chance please? |
josh-fell
approved these changes
Aug 4, 2023
ephraimbuddy
pushed a commit
that referenced
this pull request
Aug 28, 2023
By going up to `parents[3]` we were going outside the repository root, luckily(or unluckily the repo folder is also named `airflow` so the pattern `airflow/**/example_dags/example_*.py` still worked, but `tests/system/providers/**/example_*.py` wasn't being used. This discovered 2 new errors: - `example_local_to_wasb.py` was trivial to fix - `example_redis_publish.py`is more interesting: this one fails because `RedisPubSubSensor` constructor calls Redis.pubsub().subscribe(), which just hangs and DagBag fails with timeout. For now I'm just deleting this operator from the example. (cherry picked from commit c048bd5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves a couple of bugs in
test_example_dags.py.By going up to
parents[3]we were going outside the repository root, luckily (or unluckily) the repo folder is also namedairflowso the patternairflow/**/example_dags/example_*.pystill worked, buttests/system/providers/**/example_*.pywasn't used.before: collected 105 items
after: collected 695 items
This discovered 2 new errors:
example_local_to_wasb.pywas trivial to fixexample_redis_publish.py: this one fails becauseRedisPubSubSensorconstructor callsRedis.pubsub().subscribe(), which just hangs and DagBag fails with timeout. For now I'm just deleting this operator from the example.