Check Logging Handlers and Secret Backends for recursion #31385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should prevent any future errors where any of the logging handlers or secrets backend might trigger circular imports via airflows settings: This is how it will look like: 
Are there any other ways we can trigger the circular import besides logging and secret backends ? |
ashb
approved these changes
May 18, 2023
hussein-awala
approved these changes
May 18, 2023
|
We can't merge this until #31379 or something like it is fixed right? |
Right. It should fail now. |
82f0432 to
bea0dcd
Compare
vincbeck
approved these changes
May 18, 2023
eladkal
approved these changes
May 18, 2023
dstandish
approved these changes
May 18, 2023
Logging Handlers and secret backends have the potential of triggering Import/Attribute error due to circular imports. This check will attempt to import all those classes from our providers via airflow_local_settings, which should detect the case where such circular import condition is generated.
bea0dcd to
f912da4
Compare
|
Rebased after #31379 was merged. |
|
Ok. It seems to work ! |
80 tasks
potiuk
added a commit
that referenced
this pull request
Jun 9, 2023
Logging Handlers and secret backends have the potential of triggering Import/Attribute error due to circular imports. This check will attempt to import all those classes from our providers via airflow_local_settings, which should detect the case where such circular import condition is generated. (cherry picked from commit 33709f0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logging Handlers and secret backends have the potential of triggering Import/Attribute error due to circular imports. This check will attempt to import all those classes from our providers via airflow_local_settings, which should detect the case where such circular import condition is generated.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.