Upper-bind elasticearch integration #31255
Merged
+7
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladkal
approved these changes
May 12, 2023
|
BTW. We might actually want to upgrade to latest 7 if we find out that 8.* migration is complex, but I would rather do the latter. |
During bumping the dependencies of Google Provider we found out that elasticsearch >= 7.15.0 (which we never tested before because of other constraints) breaks our tests. Since there is an 8 version of eleastic search available as of 2021, we should - rather than solve the tests in 7, likely migrate to version 8, which should likely involve getting rid of elastisearch-dsl, because it has limitations of elasticsearch <8.
6a65e64 to
1432f34
Compare
jedcunningham
approved these changes
May 12, 2023
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
|
I think v8 of the module only works with Elastic, and it explicitly doesn't work with the Open Search fork anymore |
80 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During bumping the dependencies of Google Provider we found out that elasticsearch >= 7.15.0 (which we never tested before because of other constraints) breaks our tests. Since there is an 8 version of eleastic search available as of 2021, we should - rather than solve the tests in 7, likely migrate to version 8, which should likely involve getting rid of elastisearch-dsl, because it has limitations of elasticsearch <8.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.