Add deferrable param in SageMakerTrainingOperator #31042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e647c72 to
58c4b24
Compare
This will allow running SageMakerTrainingOperator in an async fashion meaning that we only submit a job from the worker to run a job and then defer to the trigger for polling to wait for the job status reaching a terminal state. This way, the worker slot won't be occupied for the whole period of task execution.
6ac82e9 to
22de2d7
Compare
potiuk
approved these changes
May 8, 2023
80 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow running SageMakerTrainingOperator in an async
fashion meaning that we only submit a job from the worker to
run a job and then defer to the trigger for polling to wait for the
job status to reach a terminal state. This way, the worker slot
won't be occupied for the whole period of task execution.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.