Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deferrable mode to WasbPrefixSensor #30252

Merged
merged 7 commits into from
Apr 22, 2023

Conversation

phanikumv
Copy link
Contributor

@phanikumv phanikumv commented Mar 23, 2023

This PR donates the WasbPrefixAsyncSensor from astronomer-providers to OSS

cc @josh-fell


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@phanikumv phanikumv changed the title [WIP]: Add WasbPrefixAsyncSensor Add WasbPrefixAsyncSensor Mar 23, 2023
@phanikumv phanikumv marked this pull request as ready for review March 24, 2023 07:09
@phanikumv phanikumv marked this pull request as draft March 24, 2023 09:59
@phanikumv phanikumv force-pushed the wasb_prefix_async branch 3 times, most recently from 14b8501 to 093d82d Compare April 4, 2023 16:06
@phanikumv phanikumv marked this pull request as ready for review April 4, 2023 16:15
@josh-fell josh-fell requested review from josh-fell and removed request for josh-fell April 4, 2023 21:52
@phanikumv phanikumv force-pushed the wasb_prefix_async branch from 093d82d to 03844a0 Compare April 5, 2023 10:47
@phanikumv phanikumv marked this pull request as draft April 5, 2023 10:47
@phanikumv phanikumv changed the title Add WasbPrefixAsyncSensor Add deferrable mode to WasbPrefixSensor Apr 5, 2023
@phanikumv phanikumv force-pushed the wasb_prefix_async branch from ff3647d to 0c67295 Compare April 5, 2023 12:59
@phanikumv phanikumv marked this pull request as ready for review April 5, 2023 13:24
@phanikumv phanikumv force-pushed the wasb_prefix_async branch 5 times, most recently from e8a8e05 to 3a63574 Compare April 11, 2023 16:23
@phanikumv phanikumv force-pushed the wasb_prefix_async branch 5 times, most recently from 9733ecb to 577cb9c Compare April 17, 2023 17:13
@potiuk
Copy link
Member

potiuk commented Apr 18, 2023

Stati checks failure.

@phanikumv phanikumv force-pushed the wasb_prefix_async branch 6 times, most recently from 914c07b to 559ac86 Compare April 20, 2023 11:21
@phanikumv
Copy link
Contributor Author

@potiuk static checks passed now.

Copy link
Contributor

@josh-fell josh-fell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some trivial updates and a suggestion on the system test. LGTM otherwise.

airflow/providers/microsoft/azure/sensors/wasb.py Outdated Show resolved Hide resolved
airflow/providers/microsoft/azure/triggers/wasb.py Outdated Show resolved Hide resolved
airflow/providers/microsoft/azure/triggers/wasb.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants