Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate DagFileProcessorManager.clear_nonexistent_import_errors to internal API #28976

Conversation

snjypl
Copy link
Contributor

@snjypl snjypl commented Jan 16, 2023

Fixes: #28785


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:Scheduler including HA (high availability) scheduler label Jan 16, 2023
@snjypl snjypl force-pushed the 28785-AIP-44-Migrate-DagFileProcessorManager.clear_nonexistent_import_errors-to-Internal-API branch 2 times, most recently from bcb48d5 to 10fe17c Compare January 17, 2023 08:29
airflow/dag_processing/manager.py Outdated Show resolved Hide resolved
airflow/dag_processing/manager.py Outdated Show resolved Hide resolved
@snjypl snjypl force-pushed the 28785-AIP-44-Migrate-DagFileProcessorManager.clear_nonexistent_import_errors-to-Internal-API branch from 10fe17c to 9c80023 Compare January 17, 2023 19:46
@snjypl
Copy link
Contributor Author

snjypl commented Jan 17, 2023

@vincbeck thanks for the review. i have made the suggested changes.

@vincbeck
Copy link
Contributor

@mhenc

@potiuk
Copy link
Member

potiuk commented Jan 20, 2023

conflicts to resolve.

@snjypl snjypl force-pushed the 28785-AIP-44-Migrate-DagFileProcessorManager.clear_nonexistent_import_errors-to-Internal-API branch from 9c80023 to 5dc704a Compare January 20, 2023 21:06
@snjypl snjypl force-pushed the 28785-AIP-44-Migrate-DagFileProcessorManager.clear_nonexistent_import_errors-to-Internal-API branch from 5dc704a to d356be9 Compare January 20, 2023 21:09
@potiuk potiuk merged commit 09b3a29 into apache:main Jan 21, 2023
@snjypl snjypl deleted the 28785-AIP-44-Migrate-DagFileProcessorManager.clear_nonexistent_import_errors-to-Internal-API branch January 21, 2023 05:36
maggesssss pushed a commit to maggesssss/airflow that referenced this pull request Jan 21, 2023
@pierrejeambrun pierrejeambrun added this to the Airflow 2.6.0 milestone Feb 27, 2023
@pierrejeambrun pierrejeambrun added changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) AIP-44 Airflow Internal API labels Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AIP-44 Airflow Internal API area:Scheduler including HA (high availability) scheduler changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AIP-44 Migrate DagFileProcessorManager.clear_nonexistent_import_errors to Internal API
4 participants