Use labels instead of pod name for pod log read in k8s exec #28546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1b0a294 to
374b042
Compare
ashb
reviewed
Dec 22, 2022
| label_selector=selector, | ||
| ).items | ||
| if not pod_list: | ||
| raise RuntimeError("Cannot find pod for ti %s", ti) |
There was a problem hiding this comment.
Instead of raising an error (which I think will result in a 500!) should we do something like we do on L191-192:
log += f"*** {str(e)}\n"
return log, {"end_of_log": True}
There was a problem hiding this comment.
it is already in a try / except so that catches and does just that
There was a problem hiding this comment.
so i could duplicate that code or just raise :)
4bdcd38 to
ad89b4e
Compare
This means we don't have to use ti.hostname as a proxy for pod name, and allows us to lift the 63 charcter limit, which was a consequence of getting pod name through hostname.
ad89b4e to
d61fe03
Compare
jedcunningham
approved these changes
Dec 30, 2022
84 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means we don't have to use ti.hostname as a proxy for pod name, and allows us to lift the 63 charcter limit, which was a consequence of getting pod name through hostname.
Using @uranusjr-style "protected" methods just, as always, to contain "public" surface area