Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup and do housekeeping with plugin examples #28537

Merged
merged 1 commit into from
Dec 22, 2022

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Dec 22, 2022

This PR performs housekeeping of the plugin examples:

  • makes the examples independent of Hive being installed
  • adds "has_access" in the examples
  • removes the misleading "metastore" (which is hive metastore not Airflow Metastore as used in other places

This way our example will be much easier to apply by anyone.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

This PR performs housekeeping of the plugin examples:

* makes the examples independent of Hive being installed
* adds "has_access" in the examples
* removes the misleading "metastore" (which is hive metastore not
  Airflow Metastore as used in other places

This way our example will be much easier to apply by anyone.
@potiuk potiuk force-pushed the housekeeping-of-plugin-examples branch from 882b2c4 to 937552f Compare December 22, 2022 21:02
@potiuk potiuk merged commit 66eb282 into apache:main Dec 22, 2022
@potiuk potiuk deleted the housekeeping-of-plugin-examples branch December 22, 2022 22:03
@potiuk potiuk added this to the Airflow 2.5.1 milestone Dec 22, 2022
@pierrejeambrun pierrejeambrun added the type:misc/internal Changelog: Misc changes that should appear in change log label Jan 9, 2023
ephraimbuddy pushed a commit that referenced this pull request Jan 12, 2023
This PR performs housekeeping of the plugin examples:

* makes the examples independent of Hive being installed
* adds "has_access" in the examples
* removes the misleading "metastore" (which is hive metastore not
  Airflow Metastore as used in other places

This way our example will be much easier to apply by anyone.

(cherry picked from commit 66eb282)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools area:plugins kind:documentation type:misc/internal Changelog: Misc changes that should appear in change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants