Unquarantine background webserver test #28249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was occasionally failing because gunicorn was not immediately launched as subprocess. This change adds extra attempts to wait for gunicorn process and unquarantines it.
uranusjr
approved these changes
Dec 9, 2022
Taragolis
approved these changes
Dec 9, 2022
|
Hmm... Sometimes test might run longer than default execution timeout 🙄 |
|
Hmm. I think we neeed to go back with that one - it is still not stable. |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Dec 9, 2022
This reverts commit 5fad8a4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test was occasionally failing because gunicorn was not immediately launched as subprocess.
This change adds extra attempts to wait for gunicorn process and unquarantines it.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.