Fix backwards compatibility for RedshiftSQLOperator

[syedahsn]

With the introduction of SQLExecuteQueryOperator, the RedshiftSQLOperator was broken. This was due to the parameter redshift_conn_id not being used. This PR fixes the issue by introducing the redshift_conn_id as a variable to pass the connection id through to the base operator.

related: #25717

---

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

[potiuk]

Nope. Why? I do not understand it. the redshift_conn_id was used. What is the problem you wanted to solve?

[potiuk]

How broken was it ? the parameter was used actually, so what you wrote does not seem correctl, maybe you expected redshift_conn_id to be set as field, but this is super-internal-detail and you should not rely on it.

@syedahsn - could you please explain?

[eladkal]

@potiuk the problem is templating
#25717 (comment)

[potiuk]

@potiuk the problem is templating #25717 (comment)

Then the right fix for it is removing "redshift_conn_id" from templated fields, not doing what the PR is doing (and adding conn_id).

[eladkal]

Then the right fix for it is removing "redshift_conn_id" from templated fields, not doing what the PR is doing.

This is a deprecared operator.
Users had redshift_con as templated field and when we added generic sql operator it broke this behavior unexpectedly. I think the goal of this PR is just to get back the functionality. Ideally we should have notice it before releasing the new operator.

[potiuk]

@syedahsn - can you please do it ? rather than adding some init_code, just removig "redshift_conn_id"/adding "conn_id" to templated_fields should fix the problem :)

[eladkal]

@syedahsn - can you please do it ? rather than adding some init_code, just removig "redshift_conn_id"/adding "conn_id" to templated_fields should fix the problem :)

Oh yeah. Right 👍

[potiuk]

Then the right fix for it is removing "redshift_conn_id" from templated fields, not doing what the PR is doing.

This is a deprecared operator. Users had redshift_con as templated field and when we added generic sql operator it broke this behavior unexpectedly. I think the goal of this PR is just to get back the functionality. Ideally we should have notice it before releasing the new operator.

The problem is not with init code, but with leaving redhshift_conn_id in templated_fields. everything will work when it is replaced with "conn_id".

[eladkal]

Yep. You are right. Its late hour here. I should not review code when I'm this tired 😴

[potiuk]

Been there, done that @eladkal :D

[syedahsn]

If I remove redshift_conn_id from the signature of the operator, workflows that have been passing a redshift_conn_id would fail right? That was how the original break was caught.

[eladkal]

You dont remove from the signature. You only remove from the templated_fields

[potiuk]

Way better :)