Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow values in WorkflowsCreateExecutionOperator execution argument to be dicts #27361

Merged
merged 2 commits into from
Oct 31, 2022

Conversation

rkarish
Copy link
Contributor

@rkarish rkarish commented Oct 29, 2022

Passing a nested dictionary to execution parameter of WorkflowsCreateExecutionOperator causes failure. Converted values in execution dictionary to be str if the are dict.
Closes: #27165


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@rkarish rkarish requested a review from turbaszek as a code owner October 29, 2022 06:02
@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Oct 29, 2022
@potiuk
Copy link
Member

potiuk commented Oct 29, 2022

Adding an explicit tests for dict is needed.

@potiuk potiuk merged commit 332c01d into apache:main Oct 31, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 31, 2022

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WorkflowsCreateExecutionOperator execution argument only receive bytes
2 participants