Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Rename schema to database in PostgresHook (#26436)" #26734

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Revert "Rename schema to database in PostgresHook (#26436)" #26734

merged 1 commit into from
Sep 27, 2022

Conversation

jedcunningham
Copy link
Member

This reverts commit 642375f.

The common sql tests didn't run in #26436, and there are failures there from this change.

I think they might point toward compatibility problems with the change, so reverting for now.

@jedcunningham
Copy link
Member Author

cc @feluelle

ashb
ashb approved these changes Sep 27, 2022
View reviewed changes
Copy link
Member

@ashb ashb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dev/breeze/src/airflow_breeze/utils/selective_checks.py is where the rules for selective checks live.

@eladkal eladkal mentioned this pull request Sep 27, 2022
Merged
@potiuk
Copy link
Member

potiuk commented Sep 27, 2022

Yep. Renaming schema will have to be done way more carefully

@jedcunningham jedcunningham mentioned this pull request Sep 27, 2022
Merged
@jedcunningham jedcunningham merged commit 685f523 into apache:main Sep 27, 2022
@jedcunningham jedcunningham deleted the revert_pghook_schema_rename branch September 27, 2022 23:06
@feluelle feluelle mentioned this pull request Sep 28, 2022
Merged
@potiuk potiuk mentioned this pull request Sep 28, 2022
Closed
89 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaxil kaxil kaxil approved these changes

@potiuk potiuk potiuk approved these changes

@ashb ashb ashb approved these changes

@mik-laj mik-laj Awaiting requested review from mik-laj

Assignees
No one assigned
Labels
area:providers kind:documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jedcunningham @potiuk @ashb @kaxil