Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DbtCloudListJobsOperator #26475

Merged
merged 2 commits into from
Sep 26, 2022
Merged

Add DbtCloudListJobsOperator #26475

merged 2 commits into from
Sep 26, 2022

Conversation

phanikumv
Copy link
Contributor

This PR adds the implementation for a DbtCloudListJobsOperator which retrieves job info from a given dbt Cloud account.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

airflow/providers/dbt/cloud/hooks/dbt.py Outdated Show resolved Hide resolved
airflow/providers/dbt/cloud/operators/dbt.py Outdated Show resolved Hide resolved
airflow/providers/dbt/cloud/operators/dbt.py Outdated Show resolved Hide resolved
airflow/providers/dbt/cloud/hooks/dbt.py Show resolved Hide resolved
airflow/providers/dbt/cloud/operators/dbt.py Outdated Show resolved Hide resolved
airflow/providers/dbt/cloud/operators/dbt.py Outdated Show resolved Hide resolved
airflow/providers/dbt/cloud/operators/dbt.py Outdated Show resolved Hide resolved
airflow/providers/dbt/cloud/operators/dbt.py Outdated Show resolved Hide resolved
@phanikumv phanikumv force-pushed the dbt-listop branch 4 times, most recently from 3f6df7c to 6a082e9 Compare September 22, 2022 10:16
Copy link
Contributor

@josh-fell josh-fell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! Just a couple minor things.

airflow/providers/dbt/cloud/operators/dbt.py Outdated Show resolved Hide resolved
@phanikumv phanikumv force-pushed the dbt-listop branch 2 times, most recently from 74606ca to 085e4d1 Compare September 23, 2022 18:18
Copy link
Contributor

@josh-fell josh-fell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's avoid f-strings in the logging call, but everything else looks great!

airflow/providers/dbt/cloud/operators/dbt.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants