Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specifying project id when calling wait_for_operation in delete/create cluster #26418

Conversation

SPTKL
Copy link
Contributor

@SPTKL SPTKL commented Sep 15, 2022

closes: #26399

Given current set up, if default gcp project is A and we are trying to call delete_cluster or create_cluster with project B, we will perform the creation and delete in project B but wait_for_operation in the default project A.
This PR will pass project_id to wait_for_operation, so we are waiting operation to complete in the GCP project passed down by delete_cluster or create_cluster

@SPTKL SPTKL requested a review from turbaszek as a code owner September 15, 2022 13:55
@boring-cyborg boring-cyborg bot added provider:cncf-kubernetes Kubernetes provider related issues area:providers provider:google Google (including GCP) related issues labels Sep 15, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Sep 15, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@potiuk
Copy link
Member

potiuk commented Sep 18, 2022

I am afraid tests are failing (and it needs rebasing)

@potiuk potiuk merged commit e315900 into apache:main Sep 20, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Sep 20, 2022

Awesome work, congrats on your first merged pull request!

@SPTKL SPTKL deleted the 26399-specify-project-id-for-gkehook-create-cluster-wait-for-operation branch September 20, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:cncf-kubernetes Kubernetes provider related issues provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GKEHook.create_cluster is not wait_for_operation using the input project_id parameter
2 participants