Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trino: Support CertificateAuthentication in the trino hook #26246

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

c2zwdjnlcg
Copy link
Contributor

Allows authenticating to trino clusters with mtls

@boring-cyborg
Copy link

boring-cyborg bot commented Sep 8, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@c2zwdjnlcg c2zwdjnlcg force-pushed the trino-mtls branch 2 times, most recently from 219c764 to cd18e96 Compare September 12, 2022 15:14
@c2zwdjnlcg c2zwdjnlcg requested review from uranusjr and removed request for mik-laj September 13, 2022 15:20
@c2zwdjnlcg
Copy link
Contributor Author

@mik-laj would you be able to take a look and approve the workflow runs? When marking the last review as updated I accidentally removed you as a reviewer

Allows authenticating to trino clusters with mtls
@c2zwdjnlcg
Copy link
Contributor Author

Thanks for the review @uranusjr . Is this mergable or do we need @mik-laj to have a look as well?

@potiuk potiuk merged commit b2766d0 into apache:main Sep 19, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Sep 19, 2022

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants