Remove cattrs from airflow.lineage
#26134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
03f1940 to
75621e7
Compare
dstandish
approved these changes
Sep 2, 2022
kaxil
approved these changes
Sep 3, 2022
75621e7 to
6a15277
Compare
kaxil
reviewed
Sep 3, 2022
kaxil
reviewed
Sep 3, 2022
|
|
||
| # prepare with manual inlets and outlets | ||
| op1.pre_execute(ctx1) | ||
| op1.post_execute(ctx1) |
There was a problem hiding this comment.
Thinking out loud, isn't it in-consistent that non-attr objects are not excluded to be set as "outlets" but excluded for inlets?
Example the following will evaluate to True currently on L149:
assert op1.outlets == [a, file3]There was a problem hiding this comment.
Yeah possibly - I didn't really change this behaviour so I didn't think about it
There was a problem hiding this comment.
@kaxil WDYT? Leave this "as it was" or fix it now?
There was a problem hiding this comment.
Would lean towards leave this "as it was" in this PR and fix it in a separate PR
6a15277 to
2a96489
Compare
Cattrs was used for two reasons: 1. As a hacky way of forcing templated fields on classes 2. As a way to store the outlets in XCom without needing pickle 1 has been fixed in core for a while now and classes can have "template_fields" properties (deeply) 2 is now done by using a combo of BaseSerialization and `attr.asdict`
0a3bcc9 to
55c9ee3
Compare
kaxil
approved these changes
Sep 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cattrs was used for two reasons:
1 has been fixed in core for a while now and classes can have
"template_fields" properties (deeply)
2 is now done by using a combo of BaseSerialization and
attr.asdictPart of #26130
Depends on #26142 (for making BaseSerialization.serialize public)