Move send_file method into SlackHook #26118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taragolis
commented
Sep 1, 2022
Comment on lines
-73
to
-76
| """ | ||
| The SlackAPIOperator calls will not fail even if the call is not unsuccessful. | ||
| It should not prevent a DAG from completing in success | ||
| """ |
There was a problem hiding this comment.
Actually slack_sdk v3 always validate response and raise an error
Taragolis
commented
Sep 1, 2022
Comment on lines
-157
to
+161
| channel="#general", | ||
| channels="#general,#random", |
There was a problem hiding this comment.
Slack API files.upload method supports upload file to multiple channels
104a292 to
3a3a4fe
Compare
potiuk
approved these changes
Sep 9, 2022
This was referenced Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move send_file into SlackHook which make this part reusable in other Operators and not only in
airflow.providers.slack.operators.slack.SlackAPIFileOperator